Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: add govulncheck #168

Open
thypon opened this issue Apr 27, 2023 · 3 comments
Open

Feature request: add govulncheck #168

thypon opened this issue Apr 27, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@thypon
Copy link
Member

thypon commented Apr 27, 2023

npm-audit for govulncheck

@thypon thypon added the enhancement New feature or request label Apr 27, 2023
@kdenhartog
Copy link
Member

@thypon or @bcaller do you have any preference how this gets implemented? This would be useful to get added into bat-go and so I was thinking about implementing it so I could require it as a part of https://github.com/brave/security/issues/829

@thypon
Copy link
Member Author

thypon commented Jun 7, 2023

It is not super clear to me if the project needs to be compilable to execute, that's what is holding me at the current stage.
It does seem to have a format very similar to reviewdog, so it should be easy to add here https://github.com/brave/security-action/blob/main/assets/reviewdog/reviewdog.yml#L55

I will give a try tomorrow

@bcaller
Copy link
Contributor

bcaller commented Jun 8, 2023

Have you tried running govulncheck on bat-go source code to see if the current recommendations make sense?

Firstly, you need to enter the directory of each module and run govulncheck from there once for each module.

For me, the output is not like in the docs. It is quite verbose, so we would need to use -json and then massage the output with jq like the other checks in reviewdog.yml.

When I ran it on bat-go/main/ I wasn't sure that it had correctly figured out the stack trace and so I wasn't sure that the results were sensible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants