Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The needs-sec-review label should block merges #328

Open
fmarier opened this issue Sep 8, 2023 · 2 comments
Open

The needs-sec-review label should block merges #328

fmarier opened this issue Sep 8, 2023 · 2 comments
Assignees
@thypon
Labels
enhancement New feature or request

Comments

@fmarier
Copy link
Member

fmarier commented Sep 8, 2023

When the security action flags a PR, we should prevent it from being merged until the label has been removed.
@fmarier fmarier added the enhancement New feature or request label Sep 8, 2023
@thypon
Copy link
Member

thypon commented Sep 9, 2023

I'm not sure we want this for every repo. We can have this as a configurable option, wdyt?

@fmarier
Copy link
Member Author

fmarier commented Sep 11, 2023

Good idea. Let's start with a few repos and so how that goes in practice.

@kdenhartog kdenhartog mentioned this issue Sep 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thypon thypon

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fmarier @thypon @bcaller