From c52f062d296fa30e1f3df8732c053c4de7d58f33 Mon Sep 17 00:00:00 2001 From: Shivan Kaul Sahib Date: Thu, 27 Jun 2024 15:17:39 -0700 Subject: [PATCH 1/2] Remove "anonymous" and "anonymized" from claim list We have many of these all over our marketing, and given that competition uses this term too, even though it's not fully accurate, I think at this point it's a commonly understood term. --- assets/semgrep_rules/client/privacy.yaml | 2 -- 1 file changed, 2 deletions(-) diff --git a/assets/semgrep_rules/client/privacy.yaml b/assets/semgrep_rules/client/privacy.yaml index 3244e0e9..a2426982 100644 --- a/assets/semgrep_rules/client/privacy.yaml +++ b/assets/semgrep_rules/client/privacy.yaml @@ -21,8 +21,6 @@ rules: severity: WARNING pattern-either: - pattern: "completely private" - - pattern: "anonymous" - - pattern: "anonymized" - pattern: "military grade" - pattern: "military-grade" - pattern: "totally secure" From 85fb08e0a0dfee80e4822bdc1e97f2d0b3865cc8 Mon Sep 17 00:00:00 2001 From: Shivan Kaul Sahib Date: Thu, 27 Jun 2024 17:34:07 -0700 Subject: [PATCH 2/2] Remove tests --- assets/semgrep_rules/client/privacy.grd | 8 -------- assets/semgrep_rules/client/privacy.md | 6 +----- 2 files changed, 1 insertion(+), 13 deletions(-) diff --git a/assets/semgrep_rules/client/privacy.grd b/assets/semgrep_rules/client/privacy.grd index 2c91bd82..1050f7a2 100644 --- a/assets/semgrep_rules/client/privacy.grd +++ b/assets/semgrep_rules/client/privacy.grd @@ -623,10 +623,6 @@ Or change later at $2brave://settings/ext Dismiss Brave search conversion, press Enter to remove this suggestion - - // ruleid: privacy - Help improve $1Brave Search by sending anonymous usage data. $2More info - Brave Search @@ -700,10 +696,6 @@ Or change later at $2brave://settings/ext Web Discovery Project - - // ruleid: privacy - Contribute some anonymous search & browsing data to refine Brave Search. - diff --git a/assets/semgrep_rules/client/privacy.md b/assets/semgrep_rules/client/privacy.md index 1a450ec0..9d92de02 100644 --- a/assets/semgrep_rules/client/privacy.md +++ b/assets/semgrep_rules/client/privacy.md @@ -1,10 +1,6 @@ // ruleid: privacy test completely private // ruleid: privacy -test anonymous -// ruleid: privacy -test anonymized -// ruleid: privacy test military grade // ruleid: privacy test military-grade @@ -17,4 +13,4 @@ test unhackable // ruleid: privacy test hackerproof // ruleid: privacy -test hacker-proof \ No newline at end of file +test hacker-proof