From f38e6499d3262dcafa871242d2dfd0b7170cb463 Mon Sep 17 00:00:00 2001 From: Artem Chaikin Date: Mon, 21 Oct 2024 17:38:30 +0100 Subject: [PATCH] fix a typo and url --- assets/semgrep_rules/client/reinterpret_cast.yaml | 2 +- assets/semgrep_rules/client/unsafe-cpp-constructs.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/assets/semgrep_rules/client/reinterpret_cast.yaml b/assets/semgrep_rules/client/reinterpret_cast.yaml index 6f950c50..25f10bcd 100644 --- a/assets/semgrep_rules/client/reinterpret_cast.yaml +++ b/assets/semgrep_rules/client/reinterpret_cast.yaml @@ -10,7 +10,7 @@ rules: thypon cdesouza-chromium languages: [cpp] - message: "Using `reinterpret_cast` against some data types may lead to undefined bheaviour. In general, when needing to do these conversions, check how Chromium upstream does them. Most of the times a reinterpret_cast is wrong and there's no guarantee the compiler will generate the code that you thought it would." + message: "Using `reinterpret_cast` against some data types may lead to undefined behaviour. In general, when needing to do these conversions, check how Chromium upstream does them. Most of the times a reinterpret_cast is wrong and there's no guarantee the compiler will generate the code that you thought it would." severity: WARNING patterns: - pattern: reinterpret_cast<$T>($ARG) diff --git a/assets/semgrep_rules/client/unsafe-cpp-constructs.yaml b/assets/semgrep_rules/client/unsafe-cpp-constructs.yaml index bf8d70c7..806c270b 100644 --- a/assets/semgrep_rules/client/unsafe-cpp-constructs.yaml +++ b/assets/semgrep_rules/client/unsafe-cpp-constructs.yaml @@ -4,7 +4,7 @@ rules: author: Artem Chaikin references: - https://github.com/brave/brave-browser/wiki/Security-reviews - source: https://github.com/brave/security-action/blob/main/assets/semgrep_rules/client/unsafe_cpp_constructs.yaml + source: https://github.com/brave/security-action/blob/main/assets/semgrep_rules/client/unsafe-cpp-constructs.yaml assignees: | stoletheminerals thypon