Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calculation_setups doesn't sync on object modification or deletion #191

Open
marc-vdm opened this issue Sep 20, 2024 · 2 comments
Open

calculation_setups doesn't sync on object modification or deletion #191

marc-vdm opened this issue Sep 20, 2024 · 2 comments

Comments

@marc-vdm
Copy link

When removing an activity or database, any calculations setups are not updated and may end up containing references to activities that do not exist anymore. This leads to errors when trying to perform a calculation.

I suggest BW checks calculation setups on deletion of activity/database and removes any matching keys from calculation setups.

@cmutel
Copy link
Member

cmutel commented Oct 2, 2024

Having to iterate over all calculation_setups is not great, but pushing this data to the database needs bigger changes to land first, so we have to...

@marc-vdm
Copy link
Author

marc-vdm commented Oct 2, 2024

I agree that this is not ideal, but IMO this should be normal BW functionality.

Note that I forgot that this is the same for impact categories upon their deletion.

And while we're at it, does bw check:

  • impact categories when deleting biosphere flows?
  • normalization/weighting when deleting impact categories?

@cmutel cmutel changed the title Deleting activity or database does not remove them from calculation setup calculation_setups doesn't sync on object modification or deletion Oct 2, 2024
cmutel added a commit that referenced this issue Oct 2, 2024
Fix database and node deletion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@cmutel @marc-vdm and others