No on_database_metadata_change signal sent when deleting database

[mrvisscher]

For some reason the on_database_metadata_change is not sent when you delete a database from the databases metadata. signal=False is hardcode instead of it using the signal parameter that defaults to True. I think the expected behavior would be for the signal to fire on database deletion as well.

brightway2-data/bw2data/meta.py

Lines 105 to 125 in 4fd8e93

	def __delitem__(self, name: str, signal: bool = True):
	from bw2data import Database
	if name not in self:
	raise KeyError
	try:
	Database(name).delete(warn=False, signal=False)
	except:
	warnings.warn(
	"""
	Deletion unsuccessful due to database error.
	Metadata state is unchanged, but database state is unknown.
	"""
	)
	return
	super(Databases, self).__delitem__(name=name, signal=False)
	if signal:
	on_database_delete.send(name=name)

[mrvisscher]

Same goes for parameterized exchanges:

brightway2-data/bw2data/parameters.py

Line 855 in 4fd8e93

ActivityParameter.recalculate_exchanges(group, signal=False)

Exchanges are recalculated, but the signal is hardcoded to False. The signal is not emitted meaning models dependent on that signal will be out of sync.