Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

Ignore file check #100

Open
ain opened this issue Sep 2, 2015 · 4 comments
Open

Ignore file check #100

ain opened this issue Sep 2, 2015 · 4 comments

Comments

@ain
Copy link
Collaborator

ain commented Sep 2, 2015

As by the story from #99, -i option could use validation. If the ignore file does not exist at the path, there should be an error (or prompt).

@cjerdonek
Copy link

FYI, erroring out or prompting at a missing file would break @brikis98's suggestion here to ignore a file that is already present. There is no other way that I know of to ignore a file.

So I would suggest that if erroring out, etc. is added as an enhancement, then an option to ignore a file that's already present be added at the same time.

@brikis98
Copy link
Owner

I'm not sure it makes sense to error out of a file you asked to ignore doesn't exist. Most other systems don't do this: e.g. .gitignore or .dockerignore. At most, a warning could be useful.

@cjerdonek
Copy link

I'm not sure it makes sense to error out of a file you asked to ignore doesn't exist.

To clarify, he's suggesting that it error out if the file you provide that specifies which files to ignore doesn't exist (e.g. the .dockerignore file) -- not if some of the files the .dockerignore file references don't exist.

@brikis98
Copy link
Owner

Ah, I misunderstood. That makes more sense.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants