Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we be able to focus the entire tree? #233

Open
kid-icarus opened this issue Mar 5, 2024 · 2 comments
Open

Should we be able to focus the entire tree? #233

kid-icarus opened this issue Mar 5, 2024 · 2 comments

Comments

@kid-icarus
Copy link

kid-icarus commented Mar 5, 2024

Some odd behavior I noticed was that, say I have a large tree that is mostly empty, if I click outside of any nodes in the tree, and then hit shift, the entire tree is focused. Is this behavior supported for any specific reason? It feels a little unintuitive because, if I actually blur away from the tree, and then click back into anywhere in the tree, and hit shift, the correct item is focused. This odd behavior becomes more pronounce when trying to multi-select via shift.

Screen.Recording.2024-03-05.at.11.34.27.AM.mov
@jameskerr
Copy link
Member

I need to think this through again. The reason had to do with keyboard navigation. If the tree has focus, you use the up and down arrows to change focus, not tab. Tab should take you to the next focusable item other than the tree. But sometimes you'd like to tab around within the focused node. This would happen if you have some action buttons on a node. Tricky.

What could be improved though in your case? Do you think if you click on the tree, the node should get the focus again? That makes sense to me.

@kid-icarus
Copy link
Author

Do you think if you click on the tree, the node should get the focus again?

Yep, I think that feels the most intuitive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants