Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not actually shipping types #465

Open
chriskrycho opened this issue Apr 17, 2020 · 0 comments
Open

Not actually shipping types #465

chriskrycho opened this issue Apr 17, 2020 · 0 comments

Comments

@chriskrycho
Copy link

This advertises that it's shipping types for TS to consume, but the files hash in package.json only ships dist, and nothing is copying the index.d.ts file from lib. (Just having a .d.ts file in the included directory will not get it published.) There are a couple ways to solve this:

  1. Since this repo increasingly uses TS itself, just add declaration: true to the compilerOptions section of tsconfig.json and move the exported type to index.d.ts. However, doing this would require a breaking change, as it would require compiling to ES Modules or otherwise switching away from the export = setup currently used in index.ts.
  2. Move it to the root of the repo and include it in files.
  3. Manually copy it as part of the build process.

I'm happy to open a PR that does any of these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant