You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This advertises that it's shipping types for TS to consume, but the files hash in package.json only ships dist, and nothing is copying the index.d.ts file from lib. (Just having a .d.ts file in the included directory will not get it published.) There are a couple ways to solve this:
Since this repo increasingly uses TS itself, just add declaration: true to the compilerOptions section of tsconfig.json and move the exported type to index.d.ts. However, doing this would require a breaking change, as it would require compiling to ES Modules or otherwise switching away from the export = setup currently used in index.ts.
Move it to the root of the repo and include it in files.
Manually copy it as part of the build process.
I'm happy to open a PR that does any of these.
The text was updated successfully, but these errors were encountered:
This advertises that it's shipping types for TS to consume, but the
files
hash inpackage.json
only shipsdist
, and nothing is copying theindex.d.ts
file fromlib
. (Just having a.d.ts
file in the included directory will not get it published.) There are a couple ways to solve this:declaration: true
to thecompilerOptions
section oftsconfig.json
and move the exported type toindex.d.ts
. However, doing this would require a breaking change, as it would require compiling to ES Modules or otherwise switching away from theexport =
setup currently used inindex.ts
.files
.I'm happy to open a PR that does any of these.
The text was updated successfully, but these errors were encountered: