Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add target column names to all insert into statements #240

Closed
NiallRees opened this issue Nov 2, 2022 · 2 comments
Closed

Add target column names to all insert into statements #240

NiallRees opened this issue Nov 2, 2022 · 2 comments
Labels
priority Priority issue or pull request quality of life A general improvement, that isn't a new feature or a bug

Comments

@NiallRees
Copy link
Contributor

Currently we don't specify the columns to insert new data into, we just rely on the column ordering. That feels brittle, and it also means that we have to always append new column to the list of columns in the insert clauses, vs putting them in the middle, which might sometimes be preferred.

DBX insert docs: https://docs.databricks.com/sql/language-manual/sql-ref-syntax-dml-insert-into.html
Snowflake insert docs: https://docs.snowflake.com/en/sql-reference/sql/insert.html
BigQuery insert docs: https://cloud.google.com/bigquery/docs/reference/standard-sql/dml-syntax

@glsdown glsdown added priority Priority issue or pull request quality of life A general improvement, that isn't a new feature or a bug labels Apr 28, 2023
@glsdown
Copy link
Contributor

glsdown commented May 12, 2023

This has also been raised in #305 , where @seub has kindly offered to take it on.

@glsdown
Copy link
Contributor

glsdown commented May 12, 2023

Closing this so it can all be kept track of in a single issue.

@glsdown glsdown closed this as completed May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority Priority issue or pull request quality of life A general improvement, that isn't a new feature or a bug
Projects
None yet
Development

No branches or pull requests

2 participants