Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploying from windows is broken #1402

Open
ahgittin opened this issue May 21, 2014 · 1 comment
Open

Deploying from windows is broken #1402

ahgittin opened this issue May 21, 2014 · 1 comment

Comments

@ahgittin
Copy link
Member

the BrooklynConfigKeys puts Os.tmp() into a freemarker template, but that results in an invalid / unparseable template on windows, probably because the temp dir has backslashes.

suggest we fix by hardcoding "/tmp/" -- it shouldn't be used in normal code paths in any case
@sjcorbett
Copy link
Member

This should be fixed by the above commit.

ZaidM pushed a commit to ZaidM/brooklyn that referenced this issue May 28, 2014
@ZaidM
Hardcode "/tmp" in BCKeys.INSTALL_DIR
010d41b 
Intended to fix issue brooklyncentral#1402
ahgittin pushed a commit that referenced this issue Jun 26, 2014
@neykov
The local system temp dir will be used on the entity's remote system.…
1de50fa 
… Instead hardcode some universal value ("/tmp"). Analogous to issue #1402.

Shouldn't we raise an error in the case where it is needed instead of passing an invalid path?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ahgittin @sjcorbett