Cannot create repository with multiple path components

[nirvdrum]

The NAME_RE regexp in GitAuth::Repo is applied to the path value in self.create. The regexp disallows the use of the '/' character, which effectively blocks the creation of repositories with subpaths. Adding in the character appears to allow creation of such repositories just fine.

[brownbeagle]

Sounds good. We should be careful not to open up parent directories in the process.

[Sutto]

I have a good idea of how to do this, will get at it tonight or this weekend. The biggest issue is backwards compatibility for us (BrownBeagle) based on the fact we still have a lot of full paths.

My thoughts on this are matching based on the longest number of directories

[brownbeagle]

I'm cool with re-remoting if that's what you mean by backwards compatibility? I think the most obvious, and so possibly the best way forward, is to make a root dir where all git repo's must be stored under - then everything else follows? This early on we're better off just going with the logical option and ignoring backwards compatibility?

[Sutto]

re-remoting is what I mean. In that case, I'll go ahead with the simpler version.

[nirvdrum]

In my case, everything is rooted in /var/git, I just have subpaths, too. So, it sounds like what you're proposing would work fine for me.

[leoc]

Were there some decisions three years ago?

I just added "/" as allowed character to NAME_RE and added a check for "..".