Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long commit messages cause tests to fail on merge #13

Open
madwort opened this issue Oct 21, 2021 · 3 comments
Open

Long commit messages cause tests to fail on merge #13

madwort opened this issue Oct 21, 2021 · 3 comments

Comments

@madwort
Copy link

madwort commented Oct 21, 2021

setup-env's default behaviour for push events generates build names that are too long to pass to BrowserStack if the commit message is long. We experienced this as tests failing after merging a PR with:

selenium.common.exceptions.WebDriverException: Message: name cannot be more than 255 characters

We're planning to work around this by passing GITHUB_SHA in place of BUILD_INFO (see also ebmdatalab/openprescribing#3239 )

@SachinMNair
Copy link

SachinMNair commented Oct 21, 2021

Hey @madwort, I have checked and yes, the build capability does not accept more than 255 characters. I will confirm it with our engineering team and get back to you

@SachinMNair
Copy link

Hey @madwort, I can confirm that the build name can be only upto 255 characters long. You can also refer this in https://www.browserstack.com/docs/automate/selenium/organize-tests

@madwort
Copy link
Author

madwort commented Jan 12, 2022

hi @SachinMNair do you think your engineering team would be willing to merge #14 ? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants