-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generalize dump_exyz and remove other dump commands #257
Comments
Any suggestion for the syntax? @erhart1
How about if we want to dump other quantities, such as per-atom virial, per-atom heat current, per-atom charge (in the future), and also want to do it only for a group of atoms? |
I think this is good change. |
I propose these:
|
Looks good. |
Currently, all commands will only have at most one (the last) instance for each run. Do you have good reasons to use more within a run? |
I have discussed with a few guys and we want to make it this way:
|
That is, |
The reason for asking about multiple commands was that I imagined wanting to dump both basic information for all atoms and additional information for a subgroup of atoms. |
Or does it? |
ok, all my proposed forms have not considered multiple instances of the command within a run. the |
Hi, on a similar note for the dump command. Would it be possible to add an option to dump unwrapped trajectories? This is particularly useful for computing diffusion coefficients via MSD and thermodynamic property calculations like surface tensions. To do that, one will equilibrate the liquid water and then unwrap the equilibrated trajectory to insert a vacuum region. I am currently doing that with other codes as postprocessing. It will be nice if there is an option from the dump commands and everything step comes within the GPUMD ecosystems. Hope this suggestion is somewhat useful. Best, |
Yes, unwrapped coordinates are now available inside the code and it can be added to this dump. I am still thinking about the syntax of this keyword, and asking for suggestions from different people. |
Are you open to the possibility to allow multiple instances of, say, the
which would allow one to write, e.g.,
|
OK, I agree with this plan, but it will take more time to do it. I have not imagined to have the same action invoked multiple times within one |
A natural question is, do we allow other commands to be invoked more than once or just the |
This starts to take on the character of the The "global" ensemble keywords, for example, should only be allowed once per run. |
So far, any keyword will only have at most one instance within each run. If there are more and the code does not complain, only the last one will take action (the previous ones will be overwritten by the last one). This is the current behavoir and we might need to state it in the documentation. Then I agree to make the |
Sounds good. |
Have this been implemented? |
Not yet. For per-atom virial, if you need time-averaged values, there is a better option: using the |
Thank you very much for this. |
I think |
No I was referring to For |
Not urgent, but need to do this at some point.
The text was updated successfully, but these errors were encountered: