New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add estimator creation section on developer/contributor guide #245

Open

salvisolamartinell opened this issue Oct 30, 2019 · 1 comment

Labels

documentation enhancement

Collaborator

salvisolamartinell commented Oct 30, 2019 •

edited by javicid

Loading

We should add a section on creating estimators on the developer/contributor guide.

Not to do any logic on the constructor.
Make constructor parameters public and do not replace them in the algorithm (maybe it's okay to modify a RandomState by using it, but not to change it for another one, and it's not ok to change a seed for a random_state, as clone()'s will fail then).
How to add it to the GridSearchCV tests.

salvisolamartinell added enhancement discuss documentation labels

Collaborator

javicid commented Nov 8, 2019

Everything in #225 should be also added to the estimator creation guide.

javicid removed the discuss label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment