Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Invoice Details view #33

Closed
dstrukt opened this issue Jun 11, 2024 · 3 comments
Closed

Implement Invoice Details view #33

dstrukt opened this issue Jun 11, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@dstrukt
Copy link
Member

dstrukt commented Jun 11, 2024

We could dump all of the Invoice detail data in this view as it currently works on mobile. The only area of concern might be the CTAS, but I'll help clean it up.

Creating a ticket to track.

Screen Shot 2024-06-10 at 11 20 13 PM
@dstrukt dstrukt added the enhancement New feature or request label Jun 11, 2024
@pavlenex
Copy link
Contributor

This is a good time to think what's actually useful information and if provided information is easy to understand.
For example

  • ambiguity between invoice and order id in the app context,
  • Created, Expiration, Monitoring, - is it clear what it is?
  • Transaction speed, is this really relevant info, it seems very subjective, shouldn't we have transaction fee instead which is a better metric?
  • Redirect URL, is it really needed?

We don't have to clean things up entirely now, but let's keep chatting about this, as I am sure improvements here can also be useful for the Server.

Screenshot 2024-06-19 at 13 09 31

@dstrukt
Copy link
Member Author

dstrukt commented Jun 19, 2024

Completely agree @pavlenex, now that we're past the basic data dump, also started to document a few areas where we could clean up or simplify these views, specifically for the App.

@dstrukt
Copy link
Member Author

dstrukt commented Aug 5, 2024

Closing, as this supersedes: #53

@dstrukt dstrukt closed this as completed Aug 5, 2024
@github-project-automation github-project-automation bot moved this from Backlog 🪵 to Done ✅ in BTCPay App Roadmap 📱 Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

3 participants