Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Additional improvements to the User Invitation flow #6233

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

UI: Additional improvements to the User Invitation flow #6233

wants to merge 5 commits into from

Conversation

dennisreimann
Copy link
Member

@dennisreimann dennisreimann commented Sep 19, 2024 •
edited
Loading

Closes #6224. Closes btcpayserver/app#48.

list

modal

@dennisreimann dennisreimann added Enhancement Improvements to an existing feature UI / UX Front-end issues, for front-end designers labels Sep 19, 2024
@dennisreimann dennisreimann force-pushed the invitation-additions branch 2 times, most recently from c9a8bff to 73344a2 Compare September 24, 2024 15:48
@dennisreimann dennisreimann mentioned this pull request Sep 24, 2024
Open
@pavlenex
Copy link
Contributor

@NicolasDorier should be done for 2.0.0

dstrukt
dstrukt suggested changes Sep 26, 2024
View reviewed changes
Copy link
Member

@dstrukt dstrukt left a comment •
edited by dennisreimann
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • think we should just keep the Details CTA our brand green

otherwise, think this looks great!

@dennisreimann
Copy link
Member Author

think we should just keep the Details CTA our brand green

As you wished, ser!

@dstrukt dstrukt self-requested a review September 26, 2024 16:43
dstrukt
dstrukt approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@dstrukt dstrukt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for indulging even the slightest of nits!

LGTM - tACK!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstrukt dstrukt dstrukt approved these changes

@NicolasDorier NicolasDorier Awaiting requested review from NicolasDorier

Assignees
No one assigned
Labels
Enhancement Improvements to an existing feature UI / UX Front-end issues, for front-end designers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Additional UI Improvements to the User Invitation flow Revocation of the invite link
3 participants
@dennisreimann @pavlenex @dstrukt