Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Offer a solution in warning messages #56

Open
dikarel opened this issue Nov 4, 2016 · 3 comments
Open

Suggestion: Offer a solution in warning messages #56

dikarel opened this issue Nov 4, 2016 · 3 comments

Comments

@dikarel
Copy link

dikarel commented Nov 4, 2016

The following warning message does not provide suggestions on how to fix the issue. I'm stuck not knowing how to fix the issue.

screen shot 2016-11-04 at 8 52 16 pm

I think it'd be educational if there's a copy-pastable link somewhere in the CLI output pointing to a resource that provides:

  • Examples on how to fix caught issues
  • In-depth rationale behind the warning

If the solution is something trivial such as deleting the offending phrase, adding an instruction (e.g. "consider removing") to the warning message would make it unambiguous.

@pluma
Copy link

pluma commented Nov 24, 2016

write-good doesn't like the word "additional". Maybe it's because I'm a non-native speaker but I have no idea what alternative it expects me to use that doesn't sound too informal. The "wordy or unneeded" messages in particular are very off-putting for the intended use case of "developer's who can't write good" -- if I knew how to write good, I wouldn't need write-good.

@heitorPB
Copy link

Oh, I'm also interested in the rationale behind the warnings/suggestions and a deeper explanation of what the "checks" mean.

@RichardLitt
Copy link
Collaborator

I think this is a good idea, and PRs would be appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants