Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change update pkg path to /data/pkg to allow for easier install on latest GoldHen #107

Closed
Masamune3210 opened this issue Feb 17, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@Masamune3210
Copy link

If the path the update pkg was downloaded to was changed to /data/pkg instead of just /data, the user would be able to just go to the package installer and install it as long as they are on the latest version of goldhen

@Masamune3210
Copy link
Author

Just realized that this sounds like a demand, I promise you I do not mean it as such. I tried to make a pull request to do it myself but....it didn't go so well

@bucanero bucanero added the enhancement New feature or request label Feb 17, 2023
@bucanero
Copy link
Owner

bucanero commented Feb 17, 2023

For backwards compatibility, I'll probably check if /data/pkg folder exists, then use it. If not, then download to /data as usual.

I also need to test the integration with the HB Store API #105 . That would also allow to update the app using the homebrew store app if the user has it installed.

@bucanero bucanero added this to the 1.4.0 milestone Apr 13, 2023
@bucanero bucanero self-assigned this Apr 14, 2023
@bucanero
Copy link
Owner

fixed in 3323439

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants