Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin request for Buf Schema Registry - danielgtaylor-betterproto v.2.0.0b6 #792

Open
lisuizhe opened this issue Sep 11, 2023 · 5 comments
Labels
Feature New feature or request

Comments

@lisuizhe
Copy link

Mandatory

Where is the source code for the plugin?

https://github.com/danielgtaylor/python-betterproto/tree/v.2.0.0b6

(we already have latest stable release v1.2.5 https://github.com/bufbuild/plugins/tree/main/plugins/community/danielgtaylor-betterproto/v1.2.5 in community plugins, but it is released 3 years before and many new changes is in 2.0.0+(even in beta)

Optional

Does the plugin have a valid semver version?

https://github.com/danielgtaylor/python-betterproto/tree/v.2.0.0b6

Does the plugin have a dependency on another plugin?

No

Does the output of this plugin depend on any other external libraries?

No

@lisuizhe lisuizhe added the Feature New feature or request label Sep 11, 2023
@mfridman
Copy link
Member

Thanks for filing an issue. Unfortunately, we only package and publish stable versions. However, let's keep this issue open to track these requests.

There's a discussion on the original issue #95 (comment)

But to summarize:

At this time, we only support stable semver versions for BSR plugins. Once that repository publishes a v2.0.0 tag, we will pick it up automatically and release it to the BSR.

@lisuizhe
Copy link
Author

Thanks for filing an issue. Unfortunately, we only package and publish stable versions. However, let's keep this issue open to track these requests.

There's a discussion on the original issue #95 (comment)

But to summarize:

At this time, we only support stable semver versions for BSR plugins. Once that repository publishes a v2.0.0 tag, we will pick it up automatically and release it to the BSR.

I see @mfridman thanks for the information. Then probably I need find some work-around at the moment

@mfridman
Copy link
Member

mfridman commented Sep 12, 2023

As much as we'd like to add all plugins, we have to be a bit careful because for each plugin (and version) we add there's a maintenance cost.

The cost goes up for unstable/unmaintained plugins. Our goal is to provide a platform to host Protobuf plugins, but we don't have the bandwidth to maintain all those public plugins. (We do maintain quite a few though, such as all the connectrpc plugins)

Paying customers have the option to upload custom plugins to their organization.

Having said all that, our hope is the community can push progress forward in the upstream https://github.com/danielgtaylor/python-betterproto project.

@soisyourface
Copy link
Contributor

I wonder if this issue should be closed. Looks like this was done here, no?

@mfridman
Copy link
Member

mfridman commented Sep 26, 2024

@soisyourface I'm afraid not, the BSR UI you linked to referring to a v2 version of the buf.gen.yaml file, and not an updated version of the upstream plugin.

Recently, some movement upstream and a beta.7 was cut, but we're still holding off for a stable semver.

https://github.com/danielgtaylor/python-betterproto/tags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants