Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Jest/Babel to work with ESM only dependencies #356

Open
GentlemanHal opened this issue Jun 2, 2023 · 0 comments
Open

Update Jest/Babel to work with ESM only dependencies #356

GentlemanHal opened this issue Jun 2, 2023 · 0 comments
Labels
dependencies Pull requests that update a dependency file for developers Changes that make development easier

Comments

@GentlemanHal
Copy link
Member

GentlemanHal commented Jun 2, 2023 •
edited
Loading

Currently we have 2 ESM only dependencies:

For screenfull I just rolled back to v5 which isn't ESM only. This is currently fine as there hasn't been any major additions or fixes in v6.

For apac-w3 I ended up adding a mock which allowed the jest tests to run.

It feels like more packages will end up moving to ESM only packages, so we should properly fix this sooner rather than later.

Some interesting reading that may help https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c
@GentlemanHal GentlemanHal converted this from a draft issue Jun 2, 2023
@GentlemanHal GentlemanHal added for developers Changes that make development easier dependencies Pull requests that update a dependency file labels Jun 2, 2023
@GentlemanHal GentlemanHal changed the title Update Jest/Babel to work with ESM only dependencies (apca-w3 and screenful) Update Jest/Babel to work with ESM only dependencies Jun 2, 2023
GentlemanHal added a commit that referenced this issue Jun 2, 2023
@GentlemanHal
chore(deps): exclude screenfull when checking for dep updates
8976cf5 
Refs: #356
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file for developers Changes that make development easier
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GentlemanHal