Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution dependencies - Code Generator depends on Tests project #24

Closed
andyward opened this issue Dec 19, 2023 · 2 comments
Closed

Solution dependencies - Code Generator depends on Tests project #24

andyward opened this issue Dec 19, 2023 · 2 comments
Assignees

Comments

@andyward
Copy link
Contributor

Internal technical issue spotted when doing PR #23 - the ids-lib.codgen project depends on the ids-tools.tests so it can re-use the code to get some buildingSmart files using the BuildingSmartRepoFiles Helper

Obviously it works but it does seem a little quirky since it creates a circular loop. e.g. If you were regenerate broken code, (or removed the generated code) you'd not be able to build to code-generator to regenerate new code. I'd expect the code generator to have no internal dependencies and be at the 'bottom' of the stack of projects.

Perhaps that helper should be factored out to a common library, or maybe just a shared file so the dependency can be broken. Alternatively, we should move the helper to codegen. Can do a PR if you like

@CBenghi
Copy link
Collaborator

CBenghi commented Mar 5, 2024

@andyward,
agreed I cut corners there a bit. I think I can live with that, but if you want to invest time fixing, a PR is welcome.

@CBenghi CBenghi closed this as completed in 5e0ecd0 Mar 6, 2024
@CBenghi CBenghi assigned CBenghi and unassigned andyward Mar 6, 2024
@CBenghi
Copy link
Collaborator

CBenghi commented Mar 6, 2024

Hi @andyward,
I had a few minutes and fixed this with the shared SolutionTooling library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants