You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Internal technical issue spotted when doing PR #23 - the ids-lib.codgen project depends on the ids-tools.tests so it can re-use the code to get some buildingSmart files using the BuildingSmartRepoFiles Helper
Obviously it works but it does seem a little quirky since it creates a circular loop. e.g. If you were regenerate broken code, (or removed the generated code) you'd not be able to build to code-generator to regenerate new code. I'd expect the code generator to have no internal dependencies and be at the 'bottom' of the stack of projects.
Perhaps that helper should be factored out to a common library, or maybe just a shared file so the dependency can be broken. Alternatively, we should move the helper to codegen. Can do a PR if you like
The text was updated successfully, but these errors were encountered:
Internal technical issue spotted when doing PR #23 - the ids-lib.codgen project depends on the ids-tools.tests so it can re-use the code to get some buildingSmart files using the BuildingSmartRepoFiles Helper
Obviously it works but it does seem a little quirky since it creates a circular loop. e.g. If you were regenerate broken code, (or removed the generated code) you'd not be able to build to code-generator to regenerate new code. I'd expect the code generator to have no internal dependencies and be at the 'bottom' of the stack of projects.
Perhaps that helper should be factored out to a common library, or maybe just a shared file so the dependency can be broken. Alternatively, we should move the helper to codegen. Can do a PR if you like
The text was updated successfully, but these errors were encountered: