Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PJS001 - Correct name of conversion based units #107

Open
aothms opened this issue Nov 3, 2023 · 1 comment
Open

PJS001 - Correct name of conversion based units #107

aothms opened this issue Nov 3, 2023 · 1 comment
Labels
rule tracker for development of a new rule/warning

Comments

@aothms
Copy link
Collaborator

aothms commented Nov 3, 2023

IfcConversionBasedUnit has a string label for its name, but the docs have a recommended table of units. I would propose the following two rules:

  • Case: use lowercase (always? or when part of the table?)
  • Value: when using a name from this table make sure the value conforms to the table.

https://ifc43-docs.standards.buildingsmart.org/IFC/RELEASE/IFC4x3/HTML/lexical/IfcConversionBasedUnit.htm

@evandroAlfieri evandroAlfieri changed the title Rule proposal: conversion based unit labels PJS001 - Correct name of conversion based units Nov 3, 2023
@evandroAlfieri evandroAlfieri added the rule tracker for development of a new rule/warning label Nov 3, 2023
@civilx64
Copy link
Contributor

civilx64 commented Nov 5, 2023

Case: use lowercase (always? or when part of the table?)

The docs state that the name is case insensitive so IMO no need to have a rule for that. But there should be a rule to ensure that the (case insensitive) name of a conversion-based unit appears in the table. Example:

US SURVEY FOOT is valid, foot_US is not.

Value: when using a name from this table make sure the value conforms to the table.

Agree, with some tolerance to account for both entering the value exactly as shown in the table versus calculating or deriving it from unit libraries. For example someone might use the pint library to derive the conversion factors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rule tracker for development of a new rule/warning
Projects
None yet
Development

No branches or pull requests

3 participants