Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part composition follow ups #180

Open
aothms opened this issue Apr 30, 2024 · 1 comment
Open

Part composition follow ups #180

aothms opened this issue Apr 30, 2024 · 1 comment

Comments

@aothms
Copy link
Collaborator

aothms commented Apr 30, 2024

          Really happy to see this kind of involvement, I'd propose one addition though:

If we read the definition of IfcFacilityPartCommon:

A part that is not clearly part of one domain but is a hybrid and has shared responsibilities in multiple domains.

Source: https://ifc43-docs.standards.buildingsmart.org/IFC/RELEASE/IFC4x3/HTML/lexical/IfcFacilityPartCommon.htm

Given that I'd recommend:

  1. that IfcFacilityPartCommon can be part of all Parts (excl IfcBuildingStorey).
  2. we double check the entry: IfcFacilityPartCommon - IfcFacility. Is that supposed to include inheritance (and is it implemented like that).

Originally posted by @aothms in #176 (comment)

@evandroAlfieri
Copy link
Collaborator

Acting as witness, when IfcFacilityPartCommon was created the idea was to handle parts that are "common" to multiple facilities, and cannot be strictly made as part of (only) the bridge, or the road, or the railway etc.

So, indeed IfcFacilityPartCommon is missing from the usage table, but as part of other facilities. Another missing entity in such table is IfcSpatialZone

To summarise, the missing rows in the decomposition table, without adding scenarios but just making sure to cover what the documentation already says, in my view are:

ApplicableEntity RelatedObjects
IfcProject IfcSpatialZone
IfcProject IfcFacilityPartCommon
IfcSite IfcSpatialZone
IfcSite IfcFacilityPartCommon
IfcBuilding IfcSpatialZone
IfcBuilding IfcFacilityPartCommon
IfcBridge IfcSpatialZone
IfcBridge IfcFacilityPartCommon
IfcRailway IfcSpatialZone
IfcRailway IfcFacilityPartCommon
IfcRoad IfcSpatialZone
IfcRoad IfcFacilityPartCommon
IfcMarineFacility IfcSpatialZone
IfcMarineFacility IfcFacilityPartCommon
IfcBuildingStorey IfcSpatialZone
IfcFacility IfcSpatialZone
IfcBridgePart IfcSpatialZone
IfcRailwayPart IfcSpatialZone
IfcRoadPart IfcSpatialZone
IfcMarinePart IfcSpatialZone
IfcFacilityPartCommon IfcSpatialZone
IfcExternalSpatialElement IfcSpatialZone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants