-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to specify target
attribute in links
#32
Comments
We could probably make it an boolean in the sequence? I think it's a valid case to be able to open it in a new tab. |
Also, how do you do the linking? Is it something you'd be able to open source? :D:D |
In part maybe. But it's quite dirty / coupled to our application ATM. |
What do you think of this @mipearson? |
The only thing I’d suggest is we be wary of the fact that this has potential security considerations (especially considering this is linking to user-specified content), albeit ones Google don’t seem too concerned about |
I think a solution for this is that we add |
Ref: #29
So the link feature is awesome:
One little downside: I wish I could specify
target="_blank"
because output pages are quite big and take a while to load, so it's a bummer when you forget to open the link in a new tab and that you have to load the output page again after.@toolmantim @keithpitt @mipearson what do you think?
I tried to implement it myself, but my go is really not good :/
The text was updated successfully, but these errors were encountered: