Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: remove "success" and "error" Button statuses #1377

Open
giogonzo opened this issue Sep 28, 2019 · 1 comment
Open

proposal: remove "success" and "error" Button statuses #1377

giogonzo opened this issue Sep 28, 2019 · 1 comment
Labels

Comments

@giogonzo
Copy link
Member

As per recent changes to the guidelines, we never use display feedback on the action performed directly inside the button UI (we typically display it alongside the submit area using different types of error UI)

For this reason, showing feedback should not be handled by this component anymore
(while the "loading" state should remain)

@giogonzo
Copy link
Member Author

Discussed offline with the rest of the team, the perception is that it would be too speculative as a change right now. Also, we might want to remove the "error" case only and keep the "success" one instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant