Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow non-string headers in TabbedPanel #1459

Open
tpetrucciani opened this issue Apr 2, 2021 · 0 comments
Open

Allow non-string headers in TabbedPanel #1459

tpetrucciani opened this issue Apr 2, 2021 · 0 comments
Labels
FE maint WIP Issues in progress

Comments

@tpetrucciani
Copy link

Currently TabbedPanel accepts only string headers. However, since it simply renders the header, accepting other React elements should be possible, and it would be useful to display SVG icons.

As an example, passing a header like

(
  <View shrink={false} vAlignContent="bottom">
    <MySvgIcon/>
    {label}
  </View>
) as any,

(bypassing type checking) seems to work OK.

@veej veej self-assigned this Sep 6, 2021
@veej veej added the WIP Issues in progress label Sep 6, 2021
@veej veej removed their assignment Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FE maint WIP Issues in progress
Projects
None yet
Development

No branches or pull requests

2 participants