Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should End Date be exactly 1 day after start date/is end date required when all day #65

Open
ScottBTR opened this issue Jan 21, 2020 · 0 comments

Comments

@ScottBTR
Copy link

eventValues.Put(CalendarContract.Events.InterfaceConsts.Dtend, newEvent.EndDate.HasValue ? newEvent.EndDate.Value.ToUnixTimeMilliseconds().ToString() : newEvent.StartDate.AddDays(1).ToString());

It looks pretty arbitrary that we're adding a day if the end date hasn't been provided. Couple of questions:

Should we be even providing an end date if it's not provided?
Why are we adding exactly 1 day?
If we need to provide a value and it will be an arbitrary number, I feel that we might want to leave a comment why about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant