Use int.TryParse instead of Convert.ToInt32 #67
Comments
ScottBTR
changed the title
ScottBTR
added a commit
that referenced
this issue
Jan 23, 2020
ScottBTR
added a commit
that referenced
this issue
Feb 6, 2020
…ters #67 Use int.TryParse instead of Convert.ToInt32
nickrandolph
added a commit
that referenced
this issue
Sep 28, 2020
* Squash Merge (#72) * #67 Use int.TryParse instead of Convert.ToInt32 * #59 rename extensions to more accurately represent their purpose * #61 replace usages of .Count == 0 with !.Any() * #62 rename cursor to something more meaningful * #66 Remove not needed Deleted flag from create+update event Also don't try to set up a null event. * #68 - Avoid abbreviations where possible * whoops, missed a change. * Changes adhere to PR feedback * PR Feedback - Replace strings with const values for ease of readability and to remove confusion around + numbers * PR Feedback allow recurrence rules to be removed for existing events. * #87 ios: delete calendar event instance * #82 drop down works for setting check boxes, but need to work out other way. * Undo permission testing code * Meeting PR Feedback * Make CalendarList readonly * Rename TimeSpanExtensions more accurately --> remove unnessacary extension RoundToNearestMinutes * Started Converting to bit flag * Update to get checkboxes functioning using bitflag * Alter according to PR requirements * CalendarDayOfWeek enum/bitflag working with UI and each platform * #89 Added Ability to SetEventRecurrenceEndDate which allows stopping event recurrences going from a specific date (end recurrence rule from date) * Remove blank line causing error. * Alter Recurrences TotalOccurrences to be null so that end date dictates the rule changes * Alter strings to use consts for consistency/readability * Altered picker to be 4 checkboxes (with custom no longer being an option) Also merged my two enums into one using condition values to determine results. * Alter as per PR feedback * Remove un-necessary using statement * Altered to PR feedback * Altered to PR feedback * Convert RecurrenceDays to readonly property * Alter ForLoop to use bitflag enum checks rather than relying on int bit logic override * Remove IsNone, IsWeekday, IsWeekly, IsAllDays --> Converter * Alter IsDaily || Is Weekly || IsMonthlyOrYearly || IsYearly --> RecurrenceTypeBoolConverter * Reoganize file and remove redundancies * missed merge change. * Resolve conflicts. * Prevent android from breaking onappearing for calendarpage Co-authored-by: Nick Randolph <[email protected]>
nickrandolph
added a commit
that referenced
this issue
Sep 29, 2020
* Squash Merge (#72) * #67 Use int.TryParse instead of Convert.ToInt32 * #59 rename extensions to more accurately represent their purpose * #61 replace usages of .Count == 0 with !.Any() * #62 rename cursor to something more meaningful * #66 Remove not needed Deleted flag from create+update event Also don't try to set up a null event. * #68 - Avoid abbreviations where possible * whoops, missed a change. * Changes adhere to PR feedback * PR Feedback - Replace strings with const values for ease of readability and to remove confusion around + numbers * PR Feedback allow recurrence rules to be removed for existing events. * #87 ios: delete calendar event instance * #82 drop down works for setting check boxes, but need to work out other way. * Undo permission testing code * Meeting PR Feedback * Make CalendarList readonly * Rename TimeSpanExtensions more accurately --> remove unnessacary extension RoundToNearestMinutes * Started Converting to bit flag * Update to get checkboxes functioning using bitflag * Alter according to PR requirements * CalendarDayOfWeek enum/bitflag working with UI and each platform * #89 Added Ability to SetEventRecurrenceEndDate which allows stopping event recurrences going from a specific date (end recurrence rule from date) * Remove blank line causing error. * Alter Recurrences TotalOccurrences to be null so that end date dictates the rule changes * Alter strings to use consts for consistency/readability * Altered picker to be 4 checkboxes (with custom no longer being an option) Also merged my two enums into one using condition values to determine results. * Alter as per PR feedback * Remove un-necessary using statement * Altered to PR feedback * Altered to PR feedback * Convert RecurrenceDays to readonly property * Alter ForLoop to use bitflag enum checks rather than relying on int bit logic override * Remove IsNone, IsWeekday, IsWeekly, IsAllDays --> Converter * Alter IsDaily || Is Weekly || IsMonthlyOrYearly || IsYearly --> RecurrenceTypeBoolConverter * Reoganize file and remove redundancies * missed merge change. * Resolve conflicts. * Prevent android from breaking onappearing for calendarpage Co-authored-by: Nick Randolph <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: