Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nil values in requests #41

Open
davidelbe opened this issue Sep 6, 2019 · 2 comments
Open

Remove nil values in requests #41

davidelbe opened this issue Sep 6, 2019 · 2 comments

Comments

@davidelbe
Copy link

It seems like a recent change to the Arbetsförmedlingen API gives an error any time you provide nil values.

We made a temporary fix just to get it working for our specific use case. Do you want a proper PR (with tests) or is this something you're already aware of/want to handle differently?

standout@15bd2d6

@buren
Copy link
Owner

buren commented Sep 8, 2019

Hi @davidelbe. A PR with tests would be great 👍

Thanks! 🌟

@davidelbe
Copy link
Author

@buren After further investigation it looks like this API is being discontinued in a few months, so I'm unsure we'll be doing any more work on this API version.

With the following changes we got it to work, but a migration to the new API will be needed soon. We could probably find a few clients that needs this done, and maybe save some time and money by joining other devs with the same issue?

master...standout:fix/nil-values

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants