Skip to content
This repository has been archived by the owner on Sep 7, 2018. It is now read-only.

buster-ci should shutdown all browsers if the process exits unexpectedly #447

Open
GCheung55 opened this issue Jan 15, 2015 · 1 comment
Assignees
Milestone

Comments

@GCheung55
Copy link
Contributor

When buster-ci is exited while tests are running, the agents (browser spawned process) is left open.

Subsequent execution of buster-ci is unaware of the agents. When buster-ci runs to the end and exits, the agents do not close and buster-ci exits the process with code 1.

I'm proposing that an exit event handler is attached to the buster-ci process to close agents if they remain open.

Some documentation on the process exit event: http://nodejs.org/api/process.html#process_event_exit

@dkl-ppi dkl-ppi self-assigned this Jan 15, 2015
@dkl-ppi
Copy link
Member

dkl-ppi commented Jan 15, 2015

Closing the browsers on process exit is something i have already on my todo list for buster-ci. I will implement it before version 1.0 of Buster.JS.

@dkl-ppi dkl-ppi added this to the 1.0 release milestone Jul 13, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants