Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn log messages into pbufs before they leave rust ffi #24

Open
qdot opened this issue Oct 26, 2020 · 0 comments
Open

Turn log messages into pbufs before they leave rust ffi #24

qdot opened this issue Oct 26, 2020 · 0 comments
Labels
Core FFI FFI Layer that sits on top of Rust enhancement New feature or request

Comments

@qdot
Copy link
Member

qdot commented Oct 26, 2020

Currently we just forward log messages as a JSON formatted string over to an FFI impl. Ideally, this should be a pbuf object. We can start this by just using serde to turn the json back into a rust object that then becomes a pbuf, but the true solution is to write a tracing formatter that actually kicks out the pbuf log object we want.

@qdot qdot added enhancement New feature or request Core FFI FFI Layer that sits on top of Rust labels Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core FFI FFI Layer that sits on top of Rust enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant