Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sensor range is unsigned, but sensor reading is signed #598

Open
CAD97 opened this issue Nov 24, 2023 · 2 comments
Open

Sensor range is unsigned, but sensor reading is signed #598

CAD97 opened this issue Nov 24, 2023 · 2 comments
Assignees
Labels

Comments

@CAD97
Copy link

CAD97 commented Nov 24, 2023

Describe the bug

Expected behavior

The sensor range and sensor reading should have the same signedness.

Actual behavior

The sensor range is an unsigned quantity and the sensor readings are signed quantities.

Additional context

The Protocol Spec says that the reading is array of signed int, and that the range info is array of array of integer (i.e. it doesn't explicitly specify signed or unsigned). The schema suggests that the reading is in the range 0..=255.

@CAD97 CAD97 added the bug label Nov 24, 2023
@qdot
Copy link
Member

qdot commented Nov 24, 2023

Yeah it's supposed to be signed.

However although the messages are defined, they're not really used at this point due to #535. There's some upcoming work to fix that, at which point we'll be doing more sensor implementation too.

@qdot
Copy link
Member

qdot commented Apr 8, 2024

These are getting updated to i32's as part of the new config format work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants