Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider switching from ShortText to Text #14

Open
andrewthad opened this issue Jul 25, 2023 · 0 comments
Open

Consider switching from ShortText to Text #14

andrewthad opened this issue Jul 25, 2023 · 0 comments

Comments

@andrewthad
Copy link
Member

Now that the text-2.x series has been out for a while, it's worth benchmarking to figure out what happens if we switch away from ShortText. I would expect that decode speed should improve in situations where most strings do not use escape sequences. This should happen because we would be performing a smaller number of bytearray allocations (an out-of-line primop), trading those in for known-sized allocations (which are lowered to code with a hot path that doesn't call another function). This will break the API, but I'm going to go ahead and get helper functions to ease this transition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant