-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deriver: derive shrinkers #191
Comments
I think it's still not clear that QCheck2 will always be the better choice. A shrinker generator would be useful. However it's not urgent, I think it's reasonable to focus on QCheck2 generators instead and do a release. |
I agree with @c-cube. The QCheck2 shrinker code is still relatively immature. Also: as I tried to illustrate in the shrink logs #172 QCheck2 sometimes has shrinker issues due to missing a splittable RNG + sub-optimal shrinker algorithms. QCheck's shrinkers are not optimal either (description in #177) - but with a couple of improvements to the As to a splittable RNG I've suggested we go with a "poor man's" implementation first. qcheck/src/runner/QCheck_base_runner.ml Line 389 in 115de55
|
If we plan on adding the shrinker deriver in the ppx, we should decide before any release the plugins names: #190. |
@jmid Have you tried either of |
I think I tried them briefly at some point. There's big news in the pipeline for 5.00 though: ocaml/ocaml#10742
|
We could derive shrinker from the type declaration. However, shouldn't we admit that people wanting shrinkers should migrate to QCheck2 instead?
ping @jmid as you mentioned this
The text was updated successfully, but these errors were encountered: