Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No space between table and days #56

Open
thisismydesign opened this issue Nov 5, 2019 · 1 comment
Open

No space between table and days #56

thisismydesign opened this issue Nov 5, 2019 · 1 comment

Comments

@thisismydesign
Copy link
Member

thisismydesign commented Nov 5, 2019 •
edited
Loading

image

vs

image

There used to be some space if you look at the picture in the readme.
@thisismydesign thisismydesign mentioned this issue Nov 5, 2019
Open
@gomorizsolt
Copy link
Collaborator

gomorizsolt commented Nov 11, 2019 •
edited
Loading

There are indeed minuscule differences between the two versions. If the @c-hive/team-contribution-calendar's version is downgraded to v0.1.0 then it appears to be the same as on the latter screenshot.

v0.2.0(btw, your texts almost touch the svg's edge for some reason)

Képernyőfotó 2019-11-11 - 16 06 28

v0.1.0

Képernyőfotó 2019-11-11 - 16 07 19

@nkapolcs has set the dx properties from -14 to -10 in #45 which makes sense because GH uses the same values as well.

Képernyőfotó 2019-11-11 - 16 24 19

Why are the texts much closer to the svg's edge in your case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@thisismydesign @nkapolcs @gomorizsolt