-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing type annotations #252
Comments
Contribution is welcome. Yeah, fill a pull request |
First batch, adding type annotations for nodes: #253 |
Also https://realpython.com/python312-typing/ removes some types boilerplate . @CoolCat467 if you accept cryptodonations in anything (like USDC/USDT/whatever), not big, just share you wallet. |
@c0fec0de may you add CI to run on #253? that is by either invite of @CoolCat467 to project or modifying CI job/project settings. |
Will Take Care next week
dzmitry-lahoda ***@***.***> schrieb am Mi., 14. Feb. 2024,
10:55:
… @c0fec0de <https://github.com/c0fec0de> may you add CI to run on #253
<#253>? that is by either invite
of @CoolCat467 <https://github.com/CoolCat467> to project or modifying CI
job/project settings.
—
Reply to this email directly, view it on GitHub
<#252 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE77IH66MQQKBJGFQWDDYZLYTSC2HAVCNFSM6AAAAABB5X53E2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBTGQZDCMRYGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
While using this project in a project of my own, when type checking my project I found that there are no type annotations for this project and therefore the type checker I am using reports that it's unable to give accurate results because this project is untyped.
I would potentially be willing to work on adding type annotations, but in the past with other projects they've said that it would be better to make an issue about it first and see if it would be worth doing instead of putting the work in to make a pull request and not have it merged.
The text was updated successfully, but these errors were encountered: