Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove showNA from api signature #11165

Open
alisman opened this issue Nov 5, 2024 · 0 comments
Open

Remove showNA from api signature #11165

alisman opened this issue Nov 5, 2024 · 0 comments
Assignees

Comments

@alisman
Copy link
Contributor

alisman commented Nov 5, 2024

This is returning NA count when it should not do so:

curl --location 'http://localhost:8082/api/column-store/clinical-data-bin-counts/fetch?dataBinMethod=STATIC' \
--header 'accept: application/json, text/plain, */*' \
--header 'accept-language: en-US,en;q=0.9' \
--header 'cache-control: no-cache' \
--header 'content-type: application/json' \
--header 'cookie: _ga_ET18FDC3P1=GS1.1.1727902893.87.0.1727902893.0.0.0; _gid=GA1.2.1570078648.1728481898; _ga_CKJ2CEEFD8=GS1.1.1728589307.172.1.1728589613.0.0.0; _ga_5260NDGD6Z=GS1.1.1728612388.318.1.1728612389.0.0.0; _gat_gtag_UA_17134933_2=1; _ga=GA1.1.1260093286.1710808634; _ga_334HHWHCPJ=GS1.1.1728647421.32.1.1728647514.0.0.0' \
--header 'pragma: no-cache' \
--header 'priority: u=1, i' \
--header 'sec-ch-ua: "Google Chrome";v="129", "Not=A?Brand";v="8", "Chromium";v="129"' \
--header 'sec-ch-ua-mobile: ?0' \
--header 'sec-ch-ua-platform: "macOS"' \
--header 'sec-fetch-dest: empty' \
--header 'user-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/129.0.0.0 Safari/537.36' \
--data '{"studyViewFilter":{"studyIds":["lgg_tcga"],"alterationFilter":{"copyNumberAlterationEventTypes":{"AMP":true,"HOMDEL":true},"mutationEventTypes":{"any":true},"includeDriver":true,"includeSomatic":true,"includeUnknownTier":true,"includeGermline":true,"includeUnknownStatus":true,"includeUnknownOncogenicity":true,"includeVUS":true},"genomicProfiles":[["mrna_median_all_sample_Zscores"]]},"attributes":[{"attributeId":"DAYS_TO_COLLECTION","showNA":false,"disableLogScale":false}]}'
@alisman alisman added the RFC80 label Nov 5, 2024
@alisman alisman changed the title RFC80 services need to respect showNA param Remove showNA from api signature Nov 11, 2024
@alisman alisman added the defer label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants