Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oncotree node "TISSUE" is showing NCI/UMLS codes in tumorTypes API #76

Open
sheridancbio opened this issue Aug 25, 2017 · 0 comments
Open
Labels
api changes to the api controller level bug

Comments

@sheridancbio
Copy link
Contributor

sheridancbio commented Aug 25, 2017

curl -X POST --header "Content-Type: application/json" --header "Accept: application/json" -d "{
"queries": [
{
"exactMatch": true,
"query": "TISSUE",
"type": "code"
}
],
"version": "oncotree_latest_stable"
}" "http://oncotree.mskcc.org/oncotree/api/tumorTypes/search"

Returns:
"data": [
[
{
"id": null,
"code": "TISSUE",
"color": null,
"name": "Tissue",
"mainType": null,
"tissue": null,
"children": {},
"parent": null,
"deprecated": false,
"history": [],
"links": null,
"level": null,
"NCI": [
"C12801"
],
"UMLS": [
"C0040300"
]
}

This oncotree node actually represents the root of the oncotree, and contains lymph and blood subtrees. So the definition from https://ncit.nci.nih.gov/ncitbrowser/pages/concept_details.jsf?dictionary=NCI%20Thesaurus&code=C12801 : "An anatomical structure consisting of similarly specialized cells and intercellular matrix, aggregated according to genetically determined spatial relationships, performing a specific function." does not seem to be accurate.

We should consider returning null for these (and all) meta values.

On the oncotree main webpage, the hover-over of node TISSUE displays "Not Available" for NCI and UMLS because the TISSUE node is not present in the tumor_Types.txt API output.

@sheridancbio sheridancbio added api changes to the api controller level bug labels Aug 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api changes to the api controller level bug
Projects
None yet
Development

No branches or pull requests

1 participant