Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expected class names are wrong #1

Open
Tishj opened this issue Mar 2, 2021 · 3 comments
Open

expected class names are wrong #1

Tishj opened this issue Mar 2, 2021 · 3 comments

Comments

@Tishj
Copy link

Tishj commented Mar 2, 2021

Project asks us to rewrite vector list queue map etc.. yet you're requiring my classes to be named List, Vector, Map

@cacharle
Copy link
Owner

cacharle commented Mar 2, 2021

Yeah, I'm not sure since their capitalized in the subject list.

Like:

  • Vector
  • List
  • Map

I guess I could support both with something like:

#ifdef LOWER_CASE_NAMES
# define VECTOR vector
# define LIST   list
# define MAP    map
#else
# define VECTOR Vector
# define LIST   List
# define MAP    Map
#endif

@cacharle
Copy link
Owner

cacharle commented Mar 2, 2021

Unfortunatly I don't have time to work on this test right now.
You can use another one or make a pull request to fix this.

@Tishj
Copy link
Author

Tishj commented Mar 2, 2021

Hmm that's a fair point, but then it's hell to test
in my own tests I just switch between using namespace std and using namespace ft to test either std/ft so I went for the exact names like std named them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants