-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docker #4362
Comments
Any update? @jbrooksuk |
Is there any way we can help this moving along? I am happy to contribute a github release workflow. |
Sorry folks! I've not actually done the Cachet Docker release before. @djdefi did all of that. If we can get a GitHub workflow going, that'd be great. |
Hey @jbrooksuk nice to hear from you! I used to use this script https://github.com/cachethq/Docker/blob/main/release-helper.sh -- Most of this could be automated in GitHub Actions like https://github.com/docker/build-push-action today instead of doing it via that manual script. On a new release of Cachet, it comes down to bumping the version here: https://github.com/cachethq/Docker/blob/e88a87d7a6cd29df8d6d1fb6f05de8678bab1782/Dockerfile#L9 and then creating the relevant GitHub tags/release and pushing the image to Dockerhub etc. It looks like we have the updates to the Dockerfile and such already in place on main, but I think I lost access to the project before being able to create the relevant tag/release for 2.4.0 Building and running it manually from |
See cachethq/Docker#426 for an initial version. Adding support for Docker Hub should be as easy as - name: Login to Docker Hub
uses: docker/login-action@v3
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_TOKEN }} And then publish the docker image like the PR does with GHCR. I skipped that mostly because I cannot publish to docker Hub (well, I could setup my own org there, but for now, GHCR was good enough). Does that help? |
I've done some cleanups, actions are still on a deprecated nodejs version, but that seems to be something they need to fix on their own. |
@djdefi good to hear from you too. Thank you for clarifying the process. I'm not a big Docker guy, so I don't know much of it, @danimo that's awesome! Thank you so much. I guess I need to replace the
|
Please never reveal plaintext secrets in commits. https://docs.github.com/en/actions/security-guides/using-secrets-in-github-actions explains how Github Action Secrets work. |
One more hint: To try out Docker Actions without polluting the main project with error messages protentially confusing to others, it's best to fork the project into your personal space, try to make Secrets work there and then create a PR with the result. Also know that the reason why GHCR.io just works is because its token is implied in GitHub Action's default environment (via |
@danimo I've already configured GitHub Actions Secrets for the repository now 👍🏻 |
I took a look, |
Would love to see an official built one, the current DockerFile etc provided doesn't work for us anymore. I guess some of the dependeicies from php7 or other are no longer available
|
If not official, is there a reliable docker container built by someone else that could be used? |
I'd love some further help to get Docker automated and up to date. Can anyone help me out here, please? 😊 |
I can, what is is that you need exactly? An adjusted workflow that works against the docker registry? The most important part (that only you can contribute) is adding the Docker Hub login credentials as described here and login. After that, simply adjust where the image is pushed to. Ping me if you are stuck. |
What kind of help is needed here? i tried to build it locally but there are a couple of dependency that do not play well with the alpine version (packages have been remove/moved). Is there a full list of the requirements and step-by-step instructions? what is in the doc for installation assumes a lot of things on the ability of the user to understand the command and have everything ready on the machine. At least to me. |
v2.4.0 is missing in docker image
The text was updated successfully, but these errors were encountered: