Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postgresql services should probably use --no-psqlrc psql option #1430

Open
autra opened this issue Sep 9, 2024 · 1 comment
Open

postgresql services should probably use --no-psqlrc psql option #1430

autra opened this issue Sep 9, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@autra
Copy link

autra commented Sep 9, 2024

Describe the bug

I've noticed that the postgresql service uses psql without specifying --no-psqlrc. It should probably, as psql behaviour can be altered substantially from user .psqlrc.

For instance, my .psqlrc displays a menu at startup with a summary of custom commands (which generates noise in the logs in this case), but most importantly, mine also sets ON_ERROR_STOP to "on", which completely messes up the service startup in case there is an error in the script (but that is another issue).

To reduce user own env influence over devenv, I suggest to add --no-psqlrc to every invocation of psql.

To reproduce

Use this gist https://gist.github.com/autra/00214a62c815d805dbd202b3492ebbbc

Copy the .psqlrc in your HOME and use devenv process up

Version
devenv 1.0.5 (x86_64-linux)

Thanks for the awesome tool btw!

@autra autra added the bug Something isn't working label Sep 9, 2024
@autra
Copy link
Author

autra commented Sep 9, 2024

If you guys agree, I can make the patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant