Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use client_ip instead of remote_ip in common formats? #45

Open
fliespl opened this issue Sep 28, 2024 · 2 comments · May be fixed by #46
Open

Use client_ip instead of remote_ip in common formats? #45

fliespl opened this issue Sep 28, 2024 · 2 comments · May be fixed by #46

Comments

@fliespl
Copy link

fliespl commented Sep 28, 2024

Is there a reason for it to be remote_ip? In loadbalancer/proxy setup it states LB ip instead of end user. Client_ip is validated by caddy - i.e. cloudflare x-connecting-ip.
@mohammed90
Copy link
Member

No reason other than it's left-over from the early days when client_ip wasn't a thing. PR is welcome if you beat us to it.

@fliespl fliespl linked a pull request Sep 28, 2024 that will close this issue
Open
@fliespl
Copy link
Author

fliespl commented Sep 28, 2024

@mohammed90 done, I wasn't sure about x-forwarded-for examples in README.md so left them intact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

switch to client_ip instead of remote_ip fliespl/transform-encoder
2 participants
@fliespl @mohammed90