From aa18e1d8bba953c535fa5b0b60e072230cfcf413 Mon Sep 17 00:00:00 2001
From: Ilya Ozherelyev <ilya.ozherelyev@uber.com>
Date: Wed, 6 Nov 2024 13:53:19 +0100
Subject: [PATCH] Add unit tests for GetVersion (#1389)

* Add unit tests for GetVersion
---
 internal/internal_event_handlers.go      |  5 ++-
 internal/internal_event_handlers_test.go | 43 ++++++++++++++++++++++++
 2 files changed, 47 insertions(+), 1 deletion(-)

diff --git a/internal/internal_event_handlers.go b/internal/internal_event_handlers.go
index 3656a639d..e009e7ca0 100644
--- a/internal/internal_event_handlers.go
+++ b/internal/internal_event_handlers.go
@@ -623,7 +623,10 @@ func (wc *workflowEnvironmentImpl) GetVersion(changeID string, minSupported, max
 		// Also upsert search attributes to enable ability to search by changeVersion.
 		version = maxSupported
 		wc.decisionsHelper.recordVersionMarker(changeID, version, wc.GetDataConverter())
-		wc.UpsertSearchAttributes(createSearchAttributesForChangeVersion(changeID, version, wc.changeVersions))
+		err := wc.UpsertSearchAttributes(createSearchAttributesForChangeVersion(changeID, version, wc.changeVersions))
+		if err != nil {
+			wc.logger.Warn("UpsertSearchAttributes failed", zap.Error(err))
+		}
 	}
 
 	validateVersion(changeID, version, minSupported, maxSupported)
diff --git a/internal/internal_event_handlers_test.go b/internal/internal_event_handlers_test.go
index 6acc7ce10..cd2e58f73 100644
--- a/internal/internal_event_handlers_test.go
+++ b/internal/internal_event_handlers_test.go
@@ -720,6 +720,49 @@ func TestSideEffect(t *testing.T) {
 	})
 }
 
+func TestGetVersion_validation(t *testing.T) {
+	t.Run("version < minSupported", func(t *testing.T) {
+		assert.PanicsWithValue(t, `Workflow code removed support of version 1. for "test" changeID. The oldest supported version is 2`, func() {
+			validateVersion("test", 1, 2, 3)
+		})
+	})
+	t.Run("version > maxSupported", func(t *testing.T) {
+		assert.PanicsWithValue(t, `Workflow code is too old to support version 3 for "test" changeID. The maximum supported version is 2`, func() {
+			validateVersion("test", 3, 1, 2)
+		})
+	})
+	t.Run("success", func(t *testing.T) {
+		validateVersion("test", 2, 1, 3)
+	})
+}
+
+func TestGetVersion(t *testing.T) {
+	t.Run("version exists", func(t *testing.T) {
+		weh := testWorkflowExecutionEventHandler(t, newRegistry())
+		weh.changeVersions = map[string]Version{
+			"test": 2,
+		}
+		res := weh.GetVersion("test", 1, 3)
+		assert.Equal(t, Version(2), res)
+	})
+	t.Run("version doesn't exist in replay", func(t *testing.T) {
+		weh := testWorkflowExecutionEventHandler(t, newRegistry())
+		weh.isReplay = true
+		res := weh.GetVersion("test", DefaultVersion, 3)
+		assert.Equal(t, DefaultVersion, res)
+		require.Contains(t, weh.changeVersions, "test")
+		assert.Equal(t, DefaultVersion, weh.changeVersions["test"])
+	})
+	t.Run("version doesn't exist without replay", func(t *testing.T) {
+		weh := testWorkflowExecutionEventHandler(t, newRegistry())
+		res := weh.GetVersion("test", DefaultVersion, 3)
+		assert.Equal(t, Version(3), res)
+		require.Contains(t, weh.changeVersions, "test")
+		assert.Equal(t, Version(3), weh.changeVersions["test"])
+		assert.Equal(t, []byte(`["test-3"]`), weh.workflowInfo.SearchAttributes.IndexedFields[CadenceChangeVersion], "ensure search attributes are updated")
+	})
+}
+
 func testWorkflowExecutionEventHandler(t *testing.T, registry *registry) *workflowExecutionEventHandlerImpl {
 	return newWorkflowExecutionEventHandler(
 		testWorkflowInfo,