New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TaskListActivitiesPerSecond does not work #555

Closed

sokada1221 opened this issue Oct 23, 2020 · 1 comment · Fixed by #556

Contributor

sokada1221 commented Oct 23, 2020

Describe the bug
Setting taskListActivitiesPerSecond via setTaskListActivitiesPerSecond() does not perform any rate limiting.

To Reproduce
Is the issue reproducible?

Yes

Steps to reproduce the behavior:

Write and run a workflow with rate limited Activity worker via setTaskListActivitiesPerSecond()
No rate limiting is performed at task list level.

Expected behavior
TaskListActivitiesPerSecond to work according to the documentation.

Screenshots
N/A

Additional context
N/A

Contributor Author

sokada1221 commented Oct 23, 2020

Root cause:
taskListActivitiesPerSecond is not properly propagated down to SingleWorkerOptions for ActivityWorker.

Will work on this fix before #553 as it's easier to resolve any possible conflicts.

sokada1221 mentioned this issue

Pass taskListActivitiesPerSecond down to ActivityWorker #556

Merged

3 tasks

meiliang86 closed this as completed in #556

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment