Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActivityCompletionClientImpl#completeExceptionally does not work #639

Open
arabczuk-equinix opened this issue Sep 22, 2021 · 1 comment
Open

Comments

@arabczuk-equinix
Copy link

The ActivityCompletionClient method does not work

com.uber.cadence.internal.sync.ActivityCompletionClientImpl#complete(com.uber.cadence.WorkflowExecution execution, java.lang.String activityId, R result)
invocation of the method always results in exception

Caused by: com.uber.cadence.client.ActivityCompletionFailureException: ActivityIdXX
Caused by: com.uber.cadence.BadRequestError: ActivityID is not set on request.

Root cause

The activityId is not set in the code when sending request to Cadence.
https://github.com/uber/cadence-java-client/blob/38667f13302eaa1bd4257d6dae476405ec1e9037/src/main/java/com/uber/cadence/internal/external/ManualActivityCompletionClientImpl.java#L134

      RespondActivityTaskFailedByIDRequest request = new RespondActivityTaskFailedByIDRequest();
      request.setReason(failure.getClass().getName());
      request.setDetails(dataConverter.toData(failure));
      request.setDomain(domain);
      request.setWorkflowID(execution.getWorkflowId());
      request.setRunID(execution.getRunId());
@arabczuk-equinix
Copy link
Author

any updates? this is quite critical

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant