Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential bugs -- Workflow.currentTimeMillis() shouldn't change during replay #669

Open
longquanzheng opened this issue Apr 13, 2022 · 1 comment
Labels

Comments

@longquanzheng
Copy link
Contributor

longquanzheng commented Apr 13, 2022

See
https://github.com/uber/cadence-java-client/blob/cb5d6ecaeb206044213d9ab2cf45bd74d6f8b654/src/main/java/com/uber/cadence/internal/replay/ClockDecisionContext.java#L185

During replay, the value passed in timer(by Workfllow.sleep() ) can impact Workflow.currentTimeMillis()` if the firing time value is later than current time.

This could cause issue for replay because the value is different from non-replay mode.

@longquanzheng
Copy link
Contributor Author

Not sure is there any application is still relying on this.

Temporal Java SDK has removed this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants