Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Documentation for Worker, where it refers that options parameter provides things like DataConverter #866

Open
Krashcan opened this issue Feb 28, 2024 · 1 comment

Comments

@Krashcan
Copy link

Krashcan commented Feb 28, 2024

This is what the documentation is for Worker constructor

/**
   * Creates worker that connects to an instance of the Cadence Service.
   *
   * @param client client to the Cadence Service endpoint.
   * @param taskList task list name worker uses to poll. It uses this name for both decision and
   *     activity task list polls.
   * @param options Options (like {@link DataConverter} override) for configuring worker.
   */

link

WorkerOptions have changed now and no longer have DataConverter . DataConverter is being passed via client.getOptions().getDataConverter() . Documentation should be modified so that it is relevant to the current state.

@Krashcan
Copy link
Author

#867

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants