We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As pointed out by @tangzhenjie in #50, using our sparse solver in the case of a vector RHS fails in the backward pass.
Unsqueezing x in SparseGenericSolve::backward and the like should solve the problem
torchsparsegradutils/torchsparsegradutils/sparse_solve.py
Line 265 in 0004528
# Unsqueeze, if necessary is_vector = (x.ndimension() == 1) if is_vector: x = x.unsqueeze(-1)
Unit tests based on the following MRE should be added:
import torch import torchsparsegradutils as tsgu A = torch.randn(12, 12, requires_grad=True).to_sparse() b = torch.randn(12, requires_grad=True) x = tsgu.sparse_generic_solve(A, b) loss = x.sum() loss.backward()
The text was updated successfully, but these errors were encountered:
Fix for #50 and #51 - Unit tests are pending
8081161
No branches or pull requests
As pointed out by @tangzhenjie in #50, using our sparse solver in the case of a vector RHS fails in the backward pass.
Unsqueezing x in SparseGenericSolve::backward and the like should solve the problem
torchsparsegradutils/torchsparsegradutils/sparse_solve.py
Line 265 in 0004528
Unit tests based on the following MRE should be added:
The text was updated successfully, but these errors were encountered: