Allow function value for "prefix" property

[bennycode]

At the moment the prefix property of a Logdown instance must be a string value:

var prefix = opts.prefix === undefined ? '' : opts.prefix

To enhance the flexbility of the prefix creation, it should be allowed to set function values too.

Example:

var demoLogger = new Logdown({
  prefix: function() {
    return new Date().toISOString() + ' MyLogger';
  }
});

[caiogondim]

Why cant you do logdown('foo', { prefix: (new Date().toISOString() + ' MyLogger') })

[caiogondim]

Since this function will only be evaluated once (at instantiation time), you can already pass the computed value.

[caiogondim]

@bennyn You cool if I close this issue?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[5angel]

@caiogondim

Why cant you do logdown('foo', { prefix: (new Date().toISOString() + ' MyLogger') })

Because it doesn't work?

I can't seem to find any indication in the source code that prefix should behave like that.

[caiogondim]

If you do use a getter it should work and we don't need to implement anything in the library.

logdown('foo', {
  get prefix() {
    return new Date().toISOString() + ' MyLogger'
  }
})

You feel we need docs for it?

[5angel]

@caiogondim absolutely. I bet many people just add timers to all log calls right now.

[5angel]

@caiogondim uhm, you sure it works? I tried the following code and it doesn't work.

[caiogondim]

Let me try.

[caiogondim]

@5angel Can you review the PR #102 ?

[5angel]

@caiogondim yup, we'll need to think more about this tho

[5angel]

So as I said in #102

Rather than modyfing the actual prefix, can't we just have a way to prepend a string to the log calls?

It may be as well be called prepend.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.